Update web-component example links#688
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how web component examples are presented in the documentation. Instead of directing users to external lit.dev playgrounds, all examples now link to internally hosted custom preview pages. This change centralizes the examples within the documentation site, removes external dependencies, and integrates example code changes directly into version control, streamlining the development and maintenance workflow for these interactive components. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a great improvement, moving web component examples from an external service to be hosted within the docsite itself. This enhances maintainability and puts the examples under source control. The changes are mostly correct, but I've found a couple of minor issues in api/web_components/index.md. One of the new links is missing a target=\"_blank\" attribute, leading to inconsistent behavior. Additionally, the link text could be more concise and consistent across the document. My suggestions aim to fix these inconsistencies.
Note: Security Review has been skipped due to the limited scope of the PR.
| See a live version of this example you can play around with | ||
| [here](examples/line-chart.html){: target="_blank"}. |
There was a problem hiding this comment.
For conciseness and improved readability, this sentence can be shortened.
| See a live version of this example you can play around with | |
| [here](examples/line-chart.html){: target="_blank"}. | |
| See a live example [here](examples/line-chart.html){: target="_blank"}. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
Instead of using lit.dev playgrounds, this PR updates the examples linked to in the web component documentation to a custom-built preview page added in #685.
This allows us to: